Re: [RFCv2 9/9] selftests: Initial TCP-AO support for fcnal-test

[Leonard Crestez]

On 11.08.2021 16:46, David Ahern wrote:
> On 8/9/21 3:35 PM, Leonard Crestez wrote:
> > Just test that a correct password is required.
>
> This test suite needs to be comprehensive that the UAPI works as
> designed and fails when it should - cleanly and with an extack message
> as to why some config option fails. Tests should cover the datapath -
> that it works properly when it should and fails cleanly when it should
> not. If addresses are involved in the configuration, then the tests need
> to be written for non VRFs, with VRFs and default VRF since addresses
> are relative.
>
> Also, in tree test suites are best for the maintenance of this code
> going forward.

I can try to integrate my python test suite into kselftest. It's not a 
very orthodox choice but a rewrite in C would be much larger.

--
Regards,
Leonard