Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

From: Jakub Kicinski
Date: Wed Aug 11 2021 - 18:17:58 EST


On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote:
> Try to fix this by using NETIF_F_GRO_HW instead so we're not
> guaranteed to be re-segmented as original.

This sentence may need rephrasing.

> Or we may want a new netdev
> feature like RX_GSO since the guest offloads for virtio-net is
> actually to receive GSO packet.
>
> Or we can try not advertise LRO is control guest offloads is not
> enabled. This solves the warning but will still slow down the traffic.

IMO gro-hw fits pretty well, patch looks good.