Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fix lpass dai link for HDMI
From: Stephen Boyd
Date: Wed Aug 11 2021 - 18:41:39 EST
Quoting Doug Anderson (2021-08-11 15:28:02)
> On Wed, Aug 11, 2021 at 12:47 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> > This should be the dai for display port. Without this set properly we
> > fail to get audio routed through external displays on trogdor. It looks
> > like we picked up v4 of this patch when there was a v7. The v7
> > patch still had the wrong sound-dai but at least we can fix all this up
> > and audio works.
> > Cc: V Sujith Kumar Reddy <vsujithk@xxxxxxxxxxxxxx>
> > Cc: Srinivasa Rao Mandadapu <srivasam@xxxxxxxxxxxxxxxx>
> > Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > Fixes: b22d313e1772 ("arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI")
> > Link: https://lore.kernel.org/r/20210721080549.28822-3-srivasam@xxxxxxxxxxxxxxxx 
> > Link: https://lore.kernel.org/r/20210726120910.20335-3-srivasam@xxxxxxxxxxxxxx 
> > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> There were other changes between v4 and v7. Do we want to take those
> too? Basically two things discussed in my response to v5 .
Will you provide a Reviewed-by if I do? :)
> 1. I think we don't need `#sound-dai-cells = <0>;`
> 2. It seemed marginally better to call the node `hdmi@5`, not `hdmi-primary@5`.
> Also, in case you're comparing to v7, it looks like v7 still had a
> bug, though, that your patch fixes. It still had "sound-dai =
> <&lpass_cpu 2>;"
> So confusing!
Thanks. Hopefully v2 is better.