Re: [PATCH v2] drm/mediatek: Add component_del in OVL and COLOR remove function

[Chun-Kuang Hu]

Hi, Jason:

jason-jh.lin <jason-jh.lin@xxxxxxxxxxxx> 於 2021年8月10日 週二 下午12:02寫道：
>
> Add component_del in OVL and COLOR remove function.

Applied to mediatek-drm-fixes [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes

Regards,
Chun-Kuang.

>
> Fixes: ff1395609e20 ("drm/mediatek: Move mtk_ddp_comp_init() from sub driver to DRM driver")
> Signed-off-by: jason-jh.lin <jason-jh.lin@xxxxxxxxxxxx>
> ---
> Change in v2:
> - add component_del function in COLOR remove function
> ---
>  drivers/gpu/drm/mediatek/mtk_disp_color.c | 2 ++
>  drivers/gpu/drm/mediatek/mtk_disp_ovl.c   | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_color.c b/drivers/gpu/drm/mediatek/mtk_disp_color.c
> index 6f4c80bbc0eb..473f5bb5cbad 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_color.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_color.c
> @@ -133,6 +133,8 @@ static int mtk_disp_color_probe(struct platform_device *pdev)
>
>  static int mtk_disp_color_remove(struct platform_device *pdev)
>  {
> +       component_del(&pdev->dev, &mtk_disp_color_component_ops);
> +
>         return 0;
>  }
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> index fa9d79963cd3..5326989d5206 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -423,6 +423,8 @@ static int mtk_disp_ovl_probe(struct platform_device *pdev)
>
>  static int mtk_disp_ovl_remove(struct platform_device *pdev)
>  {
> +       component_del(&pdev->dev, &mtk_disp_ovl_component_ops);
> +
>         return 0;
>  }
>
> --
> 2.18.0
>