Re: [PATCH 0/3] staging: r8188eu: Clean up some smatch warnings and errors

From: Phillip Potter
Date: Wed Aug 11 2021 - 20:00:26 EST


On Wed, 11 Aug 2021 at 22:58, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
>
> Smatch reports a number of warnings ans a few errors. Most are places where
> the indentation is messed up, but a few are unitialized variables or
> dereferencing a pointer before checking it.
>
> Smatch does output a false message concerning a potential memory leak.
> The pointer is saved, and the memory freed in another routine.
>
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
>
> Larry Finger (3):
> staging: r8188eu: Fix Smatch warnings for core/*.c
> staging: r8188eu: Fix smatch problems in hal/*.c
> staging: r8188eu: Fix smatch warnings in os_dep/*.c
>
> drivers/staging/r8188eu/core/rtw_br_ext.c | 2 +-
> drivers/staging/r8188eu/core/rtw_cmd.c | 6 -
> drivers/staging/r8188eu/core/rtw_ieee80211.c | 2 +-
> drivers/staging/r8188eu/core/rtw_io.c | 2 +-
> drivers/staging/r8188eu/core/rtw_led.c | 20 +--
> drivers/staging/r8188eu/core/rtw_mlme.c | 16 ++-
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 16 +--
> drivers/staging/r8188eu/core/rtw_mp.c | 6 +-
> drivers/staging/r8188eu/core/rtw_p2p.c | 4 +-
> drivers/staging/r8188eu/core/rtw_recv.c | 18 +--
> drivers/staging/r8188eu/core/rtw_security.c | 6 +-
> drivers/staging/r8188eu/core/rtw_sta_mgt.c | 6 +-
> drivers/staging/r8188eu/core/rtw_wlan_util.c | 14 +--
> drivers/staging/r8188eu/core/rtw_xmit.c | 4 +-
> .../r8188eu/hal/Hal8188ERateAdaptive.c | 16 +--
> .../staging/r8188eu/hal/HalHWImg8188E_RF.c | 2 +-
> drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
> drivers/staging/r8188eu/hal/odm.c | 18 +--
> drivers/staging/r8188eu/hal/odm_HWConfig.c | 2 +-
> .../staging/r8188eu/hal/rtl8188e_hal_init.c | 2 +-
> drivers/staging/r8188eu/hal/rtl8188e_mp.c | 8 +-
> drivers/staging/r8188eu/hal/usb_halinit.c | 18 +--
> drivers/staging/r8188eu/hal/usb_ops_linux.c | 87 +++++++------
> drivers/staging/r8188eu/os_dep/ioctl_linux.c | 58 ++++-----
> drivers/staging/r8188eu/os_dep/mlme_linux.c | 3 +-
> drivers/staging/r8188eu/os_dep/os_intfs.c | 2 +-
> .../staging/r8188eu/os_dep/osdep_service.c | 2 +-
> drivers/staging/r8188eu/os_dep/recv_linux.c | 8 +-
> drivers/staging/r8188eu/os_dep/usb_intf.c | 117 +++++++++---------
> 29 files changed, 227 insertions(+), 240 deletions(-)
>
> --
> 2.32.0
>

Dear Larry,

Sorry, but the third patch doesn't apply to my copy of the staging
tree with staging-testing tip as of now. Thanks.

Regards,
Phil