Re: [PATCH v2] fscrypt: support trusted keys
From: Mimi Zohar
Date: Wed Aug 11 2021 - 20:55:03 EST
On Wed, 2021-08-11 at 10:16 -0700, Eric Biggers wrote:
> Neither of you actually answered my question, which is whether the support for
> trusted keys in dm-crypt is a mistake. I think you're saying that it is? That
> would imply that fscrypt shouldn't support trusted keys, but rather encrypted
> keys -- which conflicts with Ahmad's patch which is adding support for trusted
> keys. Note that your reasoning for this is not documented at all in the
> trusted-encrypted keys documentation; it needs to be (email threads don't really
> matter), otherwise how would anyone know when/how to use this feature?
True, but all of the trusted-encrypted key examples in the
documentation are "encrypted" type keys, encrypted/decrypted based on a
"trusted" type key. There are no examples of using the "trusted" key
type directly. Before claiming that adding "trusted" key support in
dm-crypt was a mistake, we should ask Ahmad why he felt dm-crypt needed
to directly support "trusted" type keys.
Mimi