Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly

From: William Kucharski
Date: Wed Aug 11 2021 - 22:17:53 EST

> On Aug 11, 2021, at 4:07 PM, John Hubbard <jhubbard@xxxxxxxxxx> wrote:
> On 8/11/21 1:35 PM, William Kucharski wrote:
>> I agree that try_get_page() should probably be removed entirely; is there
>> a reason you didn't in v2 of the patch?
> Hi William,
> This patch *does* remove try_get_page() entirely! Look below. I'll reply
> inline, below, to show where that happens.

Ah, my bad. I was conflating it with try_grab_page() in patch 2/3, which
also seems like it should be an inline, but given your explanation re:
try_get_compound_head() it makes perfect sense.

For the series:

Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx>