Re: [PATCH net-next 1/2] net: sparx5: switchdev: adding frame DMA functionality

[Steen Hegelund]

Hej Jacub,

On Wed, 2021-08-11 at 15:31 -0700, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, 11 Aug 2021 09:59:08 +0200 Steen Hegelund wrote:
> > This add frame DMA functionality to the Sparx5 platform.
> > 
> > Ethernet frames can be extracted or injected autonomously to or from the
> > device’s DDR3/DDR3L memory and/or PCIe memory space. Linked list data
> > structures in memory are used for injecting or extracting Ethernet frames.
> > The FDMA generates interrupts when frame extraction or injection is done
> > and when the linked lists need updating.
> 
> Something to fix:
> 
> drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c: In function ‘sparx5_fdma_start’:
> drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c:544:6: warning: variable ‘proc_ctrl’ set but
> not used [-Wunused-but-set-variable]
>   544 |  u32 proc_ctrl;
>       |      ^~~~~~~~~

Will do.

Thanks for the review.

BR
Steen