RE: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH

[Madalin Bucur (OSS)]

> -----Original Message-----
> From: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> Sent: 12 August 2021 11:38
> To: David S . Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski
> <kuba@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx
> Cc: Madalin Bucur <madalin.bucur@xxxxxxx>; Randy Dunlap
> <rdunlap@xxxxxxxxxxxxx>; kernel-janitors@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> Subject: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig
> FSL_DPAA_ETH
> 
> The menuconfig FSL_DPAA_ETH selects config FSL_FMAN_MAC, but the config
> FSL_FMAN_MAC never existed in the kernel tree.
> 
> Hence, ./scripts/checkkconfigsymbols.py warns:
> 
> FSL_FMAN_MAC
> Referencing files: drivers/net/ethernet/freescale/dpaa/Kconfig
> 
> Remove this dead select in menuconfig FSL_DPAA_ETH.
> 
> Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> ---
>  drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/Kconfig
> b/drivers/net/ethernet/freescale/dpaa/Kconfig
> index 626ec58a0afc..0e1439fd00bd 100644
> --- a/drivers/net/ethernet/freescale/dpaa/Kconfig
> +++ b/drivers/net/ethernet/freescale/dpaa/Kconfig
> @@ -4,7 +4,6 @@ menuconfig FSL_DPAA_ETH
>  	depends on FSL_DPAA && FSL_FMAN
>  	select PHYLIB
>  	select FIXED_PHY
> -	select FSL_FMAN_MAC
>  	help
>  	  Data Path Acceleration Architecture Ethernet driver,
>  	  supporting the Freescale QorIQ chips.
> --
> 2.17.1

Acked-by: Madalin Bucur <madalin.bucur@xxxxxxxxxxx>