Re: [GIT PULL] tracing: Fixes and clean ups for v5.14

[Steven Rostedt]

On Thu, 12 Aug 2021 07:18:37 -1000
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, Aug 12, 2021 at 5:29 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > - Fix warning for use of "main" variable in osnoise tracer  
> 
> Honestly, I refuse to pull this kind of inexplicable garbage.

That was my take too, when this was first addressed:

  https://lore.kernel.org/lkml/20210730204050.46975ae2@xxxxxxxxxxxxxxxx/

> 
> The commit message talks about "some compilers/analyzers" without any
> explanation, and the "Link:" thing doesn't link to anything useful
> either.

I should have added the above link. :-/

Where the link in this commit was simply added by my scripts.

> 
> Those compilers/analyzers are clearly complete and utter crap, and my
> reaction is that I want a *lot* more explanation why we should care
> about other peoples crap.

I totally agree.

> 
> I do NOT want to see people caring about warnings that make no sense,
> certainly not without extensive explanations about why we should care
> about broken tools.
> 
> Fix the tool. Add a "--Wno-warn-about-stupid-issues" flag to the tool
> usage. Don't make pointless changes to the kernel to work around other
> peoples garbage.

:-) :-) :-)

I'm totally happy with this approach. I took the lazy method, and let
them change the variable.

But I'm 100% on your side of the issue. I HATE these stupid warnings.

I swear, these warnings are the gcc equivalent of spelling fixes to the
kernel. "Oh, I can get a patch into gcc via adding a new useless
warning!"

I'll drop the patch, and send you a v2.

-- Steve