Re: [PATCH] POWER SUPPLY CLASS/SUBSYSTEM : add new status 'Full charging' can show that the battery is fully charged but still charging

From: Sebastian Reichel
Date: Fri Aug 13 2021 - 12:35:00 EST


Hi,

On Wed, Jul 07, 2021 at 04:17:51PM +0800, zhuguanghong wrote:

Where is the long description?

Why is this needed? If userspace wants to know the details
(trickle charging vs small leak battery usage) it can always
check current_now / power_now. I think adding this will make
things more complex without any real improvement.

> Signed-off-by: zhuguanghong <zhuguanghong@xxxxxxxxxxxxx>
> ---


> drivers/power/supply/power_supply_sysfs.c | 1 +
> include/linux/power_supply.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index c3d7cbcd4fad..0ddb84b7637f 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -78,6 +78,7 @@ static const char * const POWER_SUPPLY_STATUS_TEXT[] = {
> [POWER_SUPPLY_STATUS_DISCHARGING] = "Discharging",
> [POWER_SUPPLY_STATUS_NOT_CHARGING] = "Not charging",
> [POWER_SUPPLY_STATUS_FULL] = "Full",
> + [POWER_SUPPLY_STATUS_FULL_CHARGING] = "Full charging",
> };
>
> static const char * const POWER_SUPPLY_CHARGE_TYPE_TEXT[] = {
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index be203985ecdd..04844dbb18c4 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -37,6 +37,7 @@ enum {
> POWER_SUPPLY_STATUS_DISCHARGING,
> POWER_SUPPLY_STATUS_NOT_CHARGING,
> POWER_SUPPLY_STATUS_FULL,
> + POWER_SUPPLY_STATUS_FULL_CHARGING,
> };
>
> /* What algorithm is the charger using? */
> --
> 2.20.1
>
>
>

Attachment: signature.asc
Description: PGP signature