Re: [PATCH] staging: r8188eu: Remove unnecessary ret variable in rtw_drv_init()

From: Fabio M. De Francesco
Date: Fri Aug 13 2021 - 17:55:40 EST

Next message: Daniel Borkmann: "Re: [PATCH 5.10 04/19] bpf: Add _kernel suffix to internal lockdown_bpf_read"
Previous message: Casey Schaufler: "Re: [PATCH v28 22/25] Audit: Add record for multiple process LSM attributes"
In reply to: Nathan Chancellor: "[PATCH] staging: r8188eu: Remove unnecessary ret variable in rtw_drv_init()"
Next in thread: Phillip Potter: "Re: [PATCH] staging: r8188eu: Remove unnecessary ret variable in rtw_drv_init()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Friday, August 13, 2021 10:14:18 PM CEST Nathan Chancellor wrote:
> ret is unnecessary as both error paths set the same error code so just
> return that directly.
>
> Suggested-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>

Much nicer!

Reviewed-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>

Thanks,

Fabio

Next message: Daniel Borkmann: "Re: [PATCH 5.10 04/19] bpf: Add _kernel suffix to internal lockdown_bpf_read"
Previous message: Casey Schaufler: "Re: [PATCH v28 22/25] Audit: Add record for multiple process LSM attributes"
In reply to: Nathan Chancellor: "[PATCH] staging: r8188eu: Remove unnecessary ret variable in rtw_drv_init()"
Next in thread: Phillip Potter: "Re: [PATCH] staging: r8188eu: Remove unnecessary ret variable in rtw_drv_init()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]