Re: [PATCH v2] misc_cgroup: use a counter to count the number of failures

From: Vipin Sharma
Date: Fri Aug 13 2021 - 21:17:30 EST


On Fri, Aug 13, 2021 at 5:15 PM brookxu <brookxu.cn@xxxxxxxxx> wrote:
>
> From: Chunguang Xu <brookxu@xxxxxxxxxxx>
>
> For a container, we only print an error log when the resource
> charge fails. There may be some problems here:
>
> 1. If a large number of containers are created and deleted,
> there will be a lot of error logs.
> 2. According to an error log, we cannot better understand
> the actual pressure of resources.
>
> Therefore, perhaps we should use a failcnt counter to count
> the number of failures, so that we can easily understand the
> actual pressure of resources and avoid too many error log..
>
> v2: rename failcnt to nr_fails.
>
> Signed-off-by: Chunguang Xu <brookxu@xxxxxxxxxxx>
> ---
> include/linux/misc_cgroup.h | 4 ++--
> kernel/cgroup/misc.c | 37 ++++++++++++++++++++++++++++++-------
> 2 files changed, 32 insertions(+), 9 deletions(-)
>

Acked-by: Vipin Sharma <vipinsh@xxxxxxxxxx>