Re: [PATCH] Documentation: arm: marvell: Add 88F6825 model into list

From: Pali Rohár
Date: Sat Aug 14 2021 - 11:44:36 EST


On Saturday 14 August 2021 17:39:18 Andrew Lunn wrote:
> On Sat, Aug 14, 2021 at 05:33:07PM +0200, Pali Rohár wrote:
> > On Saturday 14 August 2021 17:28:56 Andrew Lunn wrote:
> > > On Sat, Aug 14, 2021 at 02:48:05PM +0200, Pali Rohár wrote:
> > > > 88F6825 is just 88F6820 but without encryption acceleration hardware and is
> > > > used e.g. in DTS file arch/arm/boot/dts/armada-385-clearfog-gtr.dtsi
> > > >
> > > > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
> > > >
> > > > ---
> > > > Depends on patch: https://lore.kernel.org/linux-doc/20210625215437.2156-1-pali@xxxxxxxxxx/
> > > > ---
> > > > Documentation/arm/marvell.rst | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/Documentation/arm/marvell.rst b/Documentation/arm/marvell.rst
> > > > index 85169bc3f538..56bb592dbd0c 100644
> > > > --- a/Documentation/arm/marvell.rst
> > > > +++ b/Documentation/arm/marvell.rst
> > > > @@ -140,6 +140,7 @@ EBU Armada family
> > > > - 88F6821 Armada 382
> > > > - 88F6W21 Armada 383
> > > > - 88F6820 Armada 385
> > > > + - 88F6825
> > >
> > > Hi Pali
> > >
> > > Does it have the marketing name of Armada 385?
> >
> > No, there is no marking. The only name in Marvell documents and also in
> > DTS files and on wikis/internet is just 88F6825.
> >
> > I found only this statement from Marvell:
> >
> > "The 88F6825 device is a member of the ARMADA® 380, 385, and 388 Family
> > of devices."
>
> O.K, thanks

Normally I do not care about such thing... but as kernel already
supports this SoC and also have DTS file for some device, it
indicates that it is in use and supported... so mentioning this SoC in
documentation is a good idea, even it does not have "code name".

> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
>
> Andrew