Re: [PATCH v3 1/1] asus-wmi: Add support for platform_profile
From: Andy Shevchenko
Date: Sat Aug 14 2021 - 15:50:06 EST
On Sat, Aug 14, 2021 at 2:46 PM Luke Jones <luke@xxxxxxxxxx> wrote:
> On Sat, Aug 14 2021 at 12:40:39 +0300, Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Sat, Aug 14, 2021 at 7:33 AM Luke D. Jones <luke@xxxxxxxxxx> wrote:
...
> >> + pr_info("Using throttle_thermal_policy for
> >> platform_profile support\n");
> >
> > Why pr_*()?
>
> That seemed to be the convention? I see there is also dev_info(), so
> I've switched to that as it seems more appropriate.
The rule of thumb is if you have the device the message belongs to,
use dev_*(), if it's really stuff before we know anything about
devices, use pr_*(). In some cases if you have ACPI handle, you may
use acpi_handle_*().
--
With Best Regards,
Andy Shevchenko