Re: [PATCH v6 3/9] mtk-mdp: use pm_runtime in MDP component driver

From: houlong wei
Date: Sun Aug 15 2021 - 21:08:02 EST


On Mon, 2021-08-02 at 20:12 +0800, Eizan Miyamoto wrote:
> Without this change, the MDP components are not fully integrated into
> the runtime power management subsystem, and the MDP driver does not
> work.
>
> For each of the component device drivers to be able to call
> pm_runtime_get/put_sync() a pointer to the component's device struct
> had to be added to struct mtk_mdp_comp, set by mtk_mdp_comp_init().
>
> Note that the dev argument to mtk_mdp_comp_clock_on/off() has been
> removed. Those functions used to be called from the "master" mdp
> driver
> in mtk_mdp_core.c, but the component's device pointer no longer
> corresponds to the mdp master device pointer, which is not the right
> device to pass to pm_runtime_put/get_sync() which we had to add to
> get
> the driver to work properly.
>
> Signed-off-by: Eizan Miyamoto <eizan@xxxxxxxxxxxx>
> ---
>

Reviewed-by: Houlong Wei <houlong.wei@xxxxxxxxxxxx>

> (no changes since v1)
>
[...]