Re: [PATCH] staging: r8188eu: remove unused variable and DBG_88E in hal/rtl8188e_cmd.c

From: Greg KH
Date: Mon Aug 16 2021 - 03:12:29 EST

On Mon, Aug 16, 2021 at 12:05:18AM +0100, Phillip Potter wrote:
> Remove set but unused variable init_rate from rtl8188e_Add_RateATid
> function in hal/rtl8188e_cmd.c, as it fixes a kernel test robot warning.
> Removing the call to get_highest_rate_idx has no side effects here so is
> safe.
> Also remove the DBG_88E macro call in this function, as it is not
> particularly clear in my opinion. Additionally, rename variable
> shortGIrate to short_gi_rate to conform to kernel camel case rules,
> and improve general spacing around operators, some of which triggers
> checkpatch 'CHECK' messages. These are not related to the test robot
> warning.
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
> ---
> drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 22 +++++++---------------
> 1 file changed, 7 insertions(+), 15 deletions(-)

As Fabio said, this should be split up into multiple patches.

If you ever have to say "also" in a changelog text, that's a good hint
that the patch should be broken up.


greg k-h