Re: [PATCH linux-next] module: remove duplicate include in interrupt.c

From: Christophe Leroy
Date: Mon Aug 16 2021 - 07:57:43 EST




Le 16/08/2021 à 13:34, cgel.zte@xxxxxxxxx a écrit :
From: Lv Ruyi <lv.ruyi@xxxxxxxxxx>

'asm/interrupt.h' included in 'interrupt.c' is duplicated.

This patch has been submitted at least half a dozen of times already.

You should maintain alphabetic order in the include list.

But please don't post it again, we have it in the pipe already, see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/1624329437-84730-1-git-send-email-jiapeng.chong@xxxxxxxxxxxxxxxxx/

Next time please check at https://patchwork.ozlabs.org/project/linuxppc-dev/list/ before submitting a new patch.

Thanks
Christophe


Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
---
arch/powerpc/kernel/interrupt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c
index 21bbd615ca41..8a936515e4e4 100644
--- a/arch/powerpc/kernel/interrupt.c
+++ b/arch/powerpc/kernel/interrupt.c
@@ -10,7 +10,6 @@
#include <asm/cputime.h>
#include <asm/interrupt.h>
#include <asm/hw_irq.h>
-#include <asm/interrupt.h>
#include <asm/kprobes.h>
#include <asm/paca.h>
#include <asm/ptrace.h>