Re: [PATCH v5 4/7] dma-iommu: fold _swiotlb helpers into callers
From: Christoph Hellwig
Date: Mon Aug 16 2021 - 08:07:25 EST
> + if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) &&
> + (dir == DMA_TO_DEVICE ||
> + dir == DMA_BIDIRECTIONAL)) {
Nit: the two dire checks easily fit onto a single line and are easier to
follow that way.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>