RE: [PATCH v6 1/5] platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc subfolder

[Kammela, Gayatri]

> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Sent: Saturday, July 31, 2021 1:42 AM
> To: Kammela, Gayatri <gayatri.kammela@xxxxxxxxx>
> Cc: Platform Driver <platform-driver-x86@xxxxxxxxxxxxxxx>; Mark Gross
> <mgross@xxxxxxxxxxxxxxx>; Hans de Goede <hdegoede@xxxxxxxxxx>;
> Rajneesh Bhardwaj <irenic.rajneesh@xxxxxxxxx>; Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx>; You-Sheng Yang
> <vicamo.yang@xxxxxxxxxxxxx>; Pandruvada, Srinivas
> <srinivas.pandruvada@xxxxxxxxx>; Box, David E <david.e.box@xxxxxxxxx>;
> Qin, Chao <chao.qin@xxxxxxxxx>; Linux Kernel Mailing List <linux-
> kernel@xxxxxxxxxxxxxxx>; Mashiah, Tamar <tamar.mashiah@xxxxxxxxx>;
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Rajat Jain
> <rajatja@xxxxxxxxxx>; Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>;
> Alex Deucher <Alexander.Deucher@xxxxxxx>; mlimonci@xxxxxxx
> Subject: Re: [PATCH v6 1/5] platform/x86/intel: intel_pmc_core: Move
> intel_pmc_core* files to pmc subfolder
> 
> On Sat, Jul 31, 2021 at 9:10 AM Gayatri Kammela
> <gayatri.kammela@xxxxxxxxx> wrote:
> >
> > As part of collecting Intel x86 specific drivers in their own folder,
> > move intel_pmc_core* files to its own subfolder there.
> 
> ...
> 
> >  .../pmc/pltdrv.c}                             |  0
> 
> I would go further and spell it as platform.c.
Hi Andy, sure! I have renamed the file as core_platform.c in the next version , so that it is consistent with the rest of the file names under intel/pmc/ (core.c, core.h , core_platform.c)
> 
> ...
> 
> > -F:     drivers/platform/x86/intel_pmc_core*
> > +F:     drivers/platform/x86/intel/pmc/core*
> 
> This seems incorrect.
Yeah I agree. With the above change in the filename (core_platform.c), I think, this line in MAINTAINERS would make sense.
> 
> ...
> 
> > +         Supported features:
> > +               - SLP_S0_RESIDENCY counter
> > +               - PCH IP Power Gating status
> > +               - LTR Ignore / LTR Show
> 
> > +               - MPHY/PLL gating status (Sunrisepoint PCH only)
> > +               - SLPS0 Debug registers (Cannonlake/Icelake PCH)
> > +               - Low Power Mode registers (Tigerlake and beyond)
> 
> Perhaps you may use the opportunity to spell codenames in a better way, i.e.
> Sunrise Point
> Cannon Lake
> Ice Lake
> Tiger Lake
> 
> as it's done almost everywhere else in the kernel.
Sure! I have made changes as per your suggestion. Thanks!
> 
> ...
> 
> > +obj-$(CONFIG_INTEL_PMC_CORE)   += intel_pmc_core.o
> > +intel_pmc_core-objs            += core.o
> 
> objs suffix is not for kernel modules.
> Moreover, := has a difference to +=. Why is the latter in use?
Yeah, it is not needed for kernel modules. I have made changes accordingly.
> 
> > +obj-$(CONFIG_INTEL_PMC_CORE)   += pltdrv.o
> 
> This will have the very same issue as with the core module. On top of that,
> do you need a separate module for it? If so, why?
I made changes, so that we won't have the same issue as with the core module. core_pltdrv has always been made as a separate module, Andy. Do you suggest that we don't need it as a separate module?
> 
> --
> With Best Regards,
> Andy Shevchenko