Re: [PATCH] staging:iio:ade7854 surround complex defines in parentheses

From: Joe Perches
Date: Tue Aug 17 2021 - 04:51:04 EST


On Tue, 2021-08-17 at 08:12 +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 16, 2021 at 09:30:38PM -0700, daniel watson wrote:
> >
> > If this is a false positive from checkpatch, I can submit it as an
> > example to the checkpatch maintainers. Do you think I should?
>
> checkpatch is a perl script that does pattern matching, it is really
> hard for it to determine for things like this specific example, that it
> is not needed.
>
> Try finding other valid checkpatch cleanups if you wish to contribute in
> this way, there are loads of others under drivers/staging/ that should
> be easy to find.

These macros, and several other '#define ADE7854_<FOO> <value>' instances,
are apparently unused and could possibly be removed instead.