Re: [PATCH] fs: sysfs: do not remove files if group is null

From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Tue Aug 17 2021 - 12:18:11 EST


A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Aug 17, 2021 at 04:13:48PM +0000, Daniel Steger wrote:
> Hi Greg, Rafael,
>
> Have you had a chance to review this patch?

What patch?

>
> Thank You,
> Daniel
>
> -----Original Message-----
> From: Daniel Steger <daniel.steger@xxxxxxxxxx>
> Sent: Monday, August 9, 2021 1:42 PM
> To: gregkh@xxxxxxxxxxxxxxxxxxx; rafael@xxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Daniel Steger <dsteger@xxxxxxxxxx>
> Subject: [PATCH] fs: sysfs: do not remove files if group is null

What is the message id of this, I do not see it on my side at all.

>
> The current implementation allows the remove_files() API to be called without checking if the grp->name is null. Ensure that the group name is valid prior to removing files.

At the least, wrap your lines at 72 columns, we can't take this as-is...

thanks,

greg k-h