Re: [PATCH] net: dsa: lantiq_gswip: Add 200ms assert delay

From: Vladimir Oltean
Date: Tue Aug 17 2021 - 15:44:56 EST


On Tue, Aug 17, 2021 at 09:32:07PM +0200, Aleksander Jan Bajkowski wrote:
> The delay is especially needed by the xRX300 and xRX330 SoCs. Without
> this patch, some phys are sometimes not properly detected.
>
> Fixes: a09d042b086202735c4ed64 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Tested-by: Aleksander Jan Bajkowski <olek2@xxxxx> # tested on DWR966, HH5A
> ---

Generally the convention is:

From: Patch Author <patch.author@xxxxxxxxx>

Commit description

Signed-off-by: Patch Author <patch.author@xxxxxxxxx>
Signed-off-by: Patch Carrier 1 <patch.carrier1@xxxxxxxxx>
Signed-off-by: Patch Carrier 2 <patch.carrier2@xxxxxxxxx>
Signed-off-by: Patch Carrier 3 <patch.carrier3@xxxxxxxxx>
Signed-off-by: Patch Submitter <patch.submitter@xxxxxxxxx>

This patch is clearly not following this model for more than one reason.