Re: [PATCH v2 25/63] compiler_types.h: Remove __compiletime_object_size()

From: Miguel Ojeda
Date: Wed Aug 18 2021 - 09:02:34 EST


On Wed, Aug 18, 2021 at 8:14 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> Since all compilers support __builtin_object_size(), and there is only
> one user of __compiletime_object_size, remove it to avoid the needless
> indirection. This lets Clang reason about check_copy_size() correctly.

Sounds good to me, the indirection is making things more complex than
they need to be.

Reviewed-by: Miguel Ojeda <ojeda@xxxxxxxxxx>

Cheers,
Miguel