Re: [PATCH] staging: r8188eu: clean up endianness issues

From: Greg Kroah-Hartman
Date: Wed Aug 18 2021 - 16:40:52 EST


On Wed, Aug 18, 2021 at 09:22:36PM +0530, Aakash Hemadri wrote:
> Fix these sparse warnings:
>
> > rtw_br_ext.c:73:23: warning: restricted __be16 degrades to integer
>
> Here tag->tag_len is be16, use ntohs()
>
> > rtw_br_ext.c:601:57: warning: incorrect type in assignment (different base types)
> > rtw_br_ext.c:601:57: expected unsigned short
> > rtw_br_ext.c:601:57: got restricted __be16 [usertype]
>
> > rtw_br_ext.c:664:45: warning: cast to restricted __be16
> > rtw_br_ext.c:771:84: warning: incorrect type in argument 3 (different base types)
> > rtw_br_ext.c:771:84: expected unsigned int [usertype] len
>
> Cast MAGIC_CODE as unsigned short
>
> > rtw_br_ext.c:771:84: got restricted __be16 [usertype] payload_len
> > rtw_br_ext.c:773:110: warning: incorrect type in argument 2 (different base types)
> > rtw_br_ext.c:773:110: expected int len
> > rtw_br_ext.c:773:110: got restricted __be16 [usertype] payload_len
>
> > rtw_br_ext.c:836:54: warning: cast to restricted __be32
>
> Unnecessary double cast?
>
> > rtw_br_ext.c:839:70: warning: restricted __be16 degrades to integer
> > rtw_br_ext.c:845:70: warning: invalid assignment: |=
> > rtw_br_ext.c:845:70: left side has type unsigned short
> > rtw_br_ext.c:845:70: right side has type restricted __be16
>
> dhcp->flag is u16

That is a lot of different things all at once. Please break this up
into one-logical-change at a time and send a patch series.

thanks,

greg k-h