RE: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value

From: Sherry Sun
Date: Wed Aug 18 2021 - 22:03:20 EST


Hi Fabio,

> -----Original Message-----
> From: Fabio Estevam <festevam@xxxxxxxxx>
> Sent: 2021年8月19日 9:55
> To: Sherry Sun <sherry.sun@xxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Jiri Slaby
> <jirislaby@xxxxxxxxxx>; linux-serial@xxxxxxxxxxxxxxx; linux-kernel <linux-
> kernel@xxxxxxxxxxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value
>
> Hi Sherry,
>
> On Tue, Aug 17, 2021 at 3:32 AM Sherry Sun <sherry.sun@xxxxxxx> wrote:
> >
> > From: Andy Duan <fugang.duan@xxxxxxx>
> >
> > Register offset needs to be applied on mapbase also.
> > dma_tx/rx_request use the physical address of UARTDATA.
> > Register offset is currently only applied to membase (the
> > corresponding virtual addr) but not on mapbase.
> >
> > Reviewed-by: Leonard Crestez <leonard.crestez@xxxxxxx>
> > Acked-by: Fugang Duan <fugang.duan@xxxxxxx>
> > Signed-off-by: Adriana Reus <adriana.reus@xxxxxxx>
> > Signed-off-by: Sherry Sun <sherry.sun@xxxxxxx>
>
> You probably should add a Fixes tag.

That's reasonable, I will add it. Thanks!

Best regards
Sherry