Re: [PATCH 5/6] staging: r8188eu: remove function rtw_hal_free_xmit_priv
From: Fabio M. De Francesco
Date: Wed Aug 18 2021 - 22:08:28 EST
On Thursday, August 19, 2021 1:42:52 AM CEST Phillip Potter wrote:
> Remove function rtw_hal_free_xmit_priv in hal/hal_intf.c and its
> declaration in include/hal_intf.h, as well as the single call line in
> core/rtw_xmit.c. This function now essentially checks a function
> pointer which will always be NULL (due to previous patches) and
> therefore will never be called.
> Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
> drivers/staging/r8188eu/core/rtw_xmit.c | 2 --
> drivers/staging/r8188eu/hal/hal_intf.c | 6 ------
> drivers/staging/r8188eu/include/hal_intf.h | 1 -
> 3 files changed, 9 deletions(-)
It looks good.
Built with "make C=2 -j8 drivers/staging/r8188eu/ W=1"
on x86-64, it does not introduce errors or new warnings, so...
Acked-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>