Re: [PATCH 1/2] powerpc: kvm: rectify selection to PPC_DAWR

[Christophe Leroy]

Le 19/08/2021 à 11:32, Lukas Bulwahn a écrit :
> Commit a278e7ea608b ("powerpc: Fix compile issue with force DAWR")
> selects the non-existing config PPC_DAWR_FORCE_ENABLE for config
> KVM_BOOK3S_64_HANDLER. As this commit also introduces a config PPC_DAWR,
> it probably intends to select PPC_DAWR instead.
>
> Rectify the selection in config KVM_BOOK3S_64_HANDLER to PPC_DAWR.
>
> The issue was identified with ./scripts/checkkconfigsymbols.py.
>
> Fixes: a278e7ea608b ("powerpc: Fix compile issue with force DAWR")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> ---
>   arch/powerpc/kvm/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> index e45644657d49..aa29ea56c80a 100644
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -38,7 +38,7 @@ config KVM_BOOK3S_32_HANDLER
>   config KVM_BOOK3S_64_HANDLER
>   	bool
>   	select KVM_BOOK3S_HANDLER
> -	select PPC_DAWR_FORCE_ENABLE
> +	select PPC_DAWR

That's useless, see https://elixir.bootlin.com/linux/v5.14-rc6/source/arch/powerpc/Kconfig#L267

In arch/powerpc/Kconfig, you already have:

	select PPC_DAWR				if PPC64




>   
>   config KVM_BOOK3S_PR_POSSIBLE
>   	bool