Re: [PATCH] misc/pvpanic: fix set driver data

[Andy Shevchenko]

On Wed, Aug 18, 2021 at 06:38:30PM +0300, Mihai Carabas wrote:

Thank you for the report and fix! My comments below.

> Add again dev_set_drvdata in order for dev_get_drvdata to not return NULL.

dev_set_drvdata()
dev_get_drvdata()

> Fixes: 394febc9d0a6 ("misc/pvpanic: Make 'pvpanic_probe()' resource managed")

> 

Shouldn't be blank line(s) in the tag block.

> Signed-off-by: Mihai Carabas <mihai.carabas@xxxxxxxxxx>

...

> +	dev_set_drvdata(dev, pi);
> +
>  	return devm_pvpanic_probe(dev, pi);

I think it makes sense to have the above line as a part of pvpanic_probe().

-- 
With Best Regards,
Andy Shevchenko