Re: [PATCH] media: atomisp: restore missing 'return' statement

From: Pavel Skripkin
Date: Thu Aug 19 2021 - 15:22:45 EST

On 8/19/21 8:24 PM, Andy Shevchenko wrote:
On Fri, Aug 13, 2021 at 7:39 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:

On Mon, Aug 02, 2021 at 04:38:14PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> The input_system_configure_channel_sensor() function lost its final
> return code in a previous patch:
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> Restore what was there originally.
> Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

I hit this too. Thanks!

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

Me too,
Tested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Pavel, how have you tested it?

To he honest, I didn't test it at all. It was part of application processes to LFX mentoship. I really don't like style changes. Anyway, I have to do it to pass the task, so, yeah, I messed up with this one ;(

Also, I didn't notice when patch was applied, because I was like 2 month after v3 posted. I am so sorry for this situation. Nowadays I always test my patches.

I was young and foolish :)

With regards,
Pavel Skripkin