Re: [RFC PATCH 11/15] arm64: dts: qcom: sdm845-db845c: switch bt+wifi to qca power sequencer

From: Bjorn Andersson
Date: Thu Aug 19 2021 - 19:38:48 EST


On Mon 16 Aug 17:55 PDT 2021, Dmitry Baryshkov wrote:

> Switch sdm845-db845c device tree to use new power sequencer driver
> rather than separate regulators.
>

LGTM!

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 21 ++++++++++++++-------
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
> 2 files changed, 20 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index 2d5533dd4ec2..c9b694e934d4 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -629,6 +629,16 @@ &qupv3_id_1 {
> status = "okay";
> };
>
> +&qca_pwrseq {
> + status = "okay";
> +
> + vddio-supply = <&vreg_s4a_1p8>;
> +
> + vddxo-supply = <&vreg_l7a_1p8>;
> + vddrfa-supply = <&vreg_l17a_1p3>;
> + vddch0-supply = <&vreg_l25a_3p3>;
> +};
> +
> &sdhc_2 {
> status = "okay";
>
> @@ -916,10 +926,8 @@ &uart6 {
> bluetooth {
> compatible = "qcom,wcn3990-bt";
>
> - vddio-supply = <&vreg_s4a_1p8>;
> - vddxo-supply = <&vreg_l7a_1p8>;
> - vddrf-supply = <&vreg_l17a_1p3>;
> - vddch0-supply = <&vreg_l25a_3p3>;
> + bt-pwrseq = <&qca_pwrseq 1>;

I suppose there will be a DT binding and some defines for the WiFi/BT
argument to &qca_pwrseq?

Regards,
Bjorn

> +
> max-speed = <3200000>;
> };
> };
> @@ -1036,9 +1044,8 @@ &wifi {
> status = "okay";
>
> vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
> - vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
> - vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
> - vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
> +
> + wifi-pwrseq = <&qca_pwrseq 0>;
>
> qcom,snoc-host-cap-8bit-quirk;
> };
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 0a86fe71a66d..78e889b2c8dd 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -1051,6 +1051,12 @@ psci {
> method = "smc";
> };
>
> + qca_pwrseq: qca-pwrseq {
> + compatible = "qcom,wcn3990-pwrseq";
> + #pwrseq-cells = <1>;
> + status = "disabled";
> + };
> +
> soc: soc@0 {
> #address-cells = <2>;
> #size-cells = <2>;
> --
> 2.30.2
>