RE: [PATCH 05/16] iio: adc: max1027: Drop extra warning message

From: Sa, Nuno
Date: Fri Aug 20 2021 - 03:13:19 EST




> -----Original Message-----
> From: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> Sent: Wednesday, August 18, 2021 1:11 PM
> To: Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen
> <lars@xxxxxxxxxx>
> Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>; linux-
> iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Miquel Raynal
> <miquel.raynal@xxxxxxxxxxx>
> Subject: [PATCH 05/16] iio: adc: max1027: Drop extra warning message
>
> [External]
>
> Memory allocation errors automatically trigger the right logs, no need
> to have our own.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---
> drivers/iio/adc/max1027.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c
> index d79dabf20567..ac603b4ca787 100644
> --- a/drivers/iio/adc/max1027.c
> +++ b/drivers/iio/adc/max1027.c
> @@ -461,10 +461,8 @@ static int max1027_probe(struct spi_device
> *spi)
> st->buffer = devm_kmalloc_array(&indio_dev->dev,
> indio_dev->num_channels, 2,
> GFP_KERNEL);
> - if (st->buffer == NULL) {
> - dev_err(&indio_dev->dev, "Can't allocate buffer\n");
> + if (!st->buffer)
> return -ENOMEM;
> - }
>
> if (spi->irq) {
> ret = devm_iio_triggered_buffer_setup(&spi->dev,
> indio_dev,
> --
> 2.27.0

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>