Re: [PATCH v4 0/1] asus-wmi: Add support for custom fan curves

[Luke Jones]

Hi Hans,

Yes sorry about that. It is now stabilised and ready for review. I 
don't expect any more changes unless some of the folks testing it find 
issues - and then I'll hold off on new versions until first review is 
completed.

Cheers,
Luke.

On Fri, Aug 20 2021 at 12:05:15 +0200, Hans de Goede 
<hdegoede@xxxxxxxxxx> wrote:
> Hi Luke,
> On 8/20/21 11:57 AM, Luke D. Jones wrote:
> >  Add support for custom fan curves found on some ASUS ROG laptops.
> >
> >  The patch has gone through a few revisions as others tested it and
> >  requested bahaviour changes or reported issues. V4 should be 
> > considered
> >  finalised for now and I won't submit a new version until V4 has been
> >  reviewed.
> >
> >  - V1
> >    + Initial patch work
> >  - V2
> >    + Don't fail and remove wmi driver if error from
> >      asus_wmi_evaluate_method_buf() if error is -ENODEV
> >  - V3
> >    + Store the "default" fan curves
> >    + Call throttle_thermal_policy_write() if a curve is erased to 
> > ensure
> >      that the factory default for a profile is applied again
> >  - V4
> >    + Do not apply default curves by default. Testers have found that 
> > the
> >      default curves don't quite match actual no-curve behaviours
> >    + Add method to enable/disable curves for each profile
>
> You are sending new revisions pretty fast. I don't really have an 
> issue
> with that, but can you let me know when you think this has stabilized
> a bit ?  Then I can review it when it is not changing so much anymore 
> :)
>
> Regards,
>
> Hans