Re: [PATCH 13/13] mtd: spinand: Add support for Winbond W35N01JW SPI NAND flash

[Apurva Nandan]

On 20/08/21 5:32 pm, Miquel Raynal wrote:
> Hi Apurva,
>
> Apurva Nandan <a-nandan@xxxxxx> wrote on Fri, 20 Aug 2021 17:21:33
> +0530:
>
> > Hi Miquèl,
> >
> > On 07/08/21 12:44 am, Miquel Raynal wrote:
> > > Hi Apurva,
> > >
> > > Apurva Nandan <a-nandan@xxxxxx> wrote on Tue, 13 Jul 2021 13:05:38
> > > +0000:
> > >    
> > > > Winbond W35N01JW is SPI NAND flash supporting Octal DTR SPI protocol.
> > >
> > >                        a
> > >    
> > > > Add op_vairants for W35N01JW, which include the Octal DTR read/write
> > >
> > > variants
> > >    
> > > > page ops as well. Add W35N01JW's oob layout functions for the
> > >
> > >                                      OOB
> > >    
> >
> > Okay, will correct these.
> >
> > > > mtd_ooblayout_ops. Add all op adjustments required for Octal DTR SPI
> > > > mode using the adjust_op(). Finally, add an entry for W35N01JW in
> > > > spinand_info table.
> > > >
> > > > Datasheet: https://www.winbond.com/export/sites/winbond/datasheet/W35N01JW_Datasheet_Brief.pdf
> > > >   
> > >
> > > Maybe we can split this into two parts:
> > > 1/ support the chip
> > > 2/ add 8-D support
> > >    
> >
> > I can split the patch into:
> > 1/ Add implementation of manufacturer_ops: adjust_op() to handle variations of ops in 8D-8D-8D mode
> > 2/ Add support/entry for Winbond W35N01JW SPI NAND flash chip
> >
> > As 8-D support has already been added in a previous patch.
>
> I also don't want the renaming to happen in the patch adding more
> logic.

Okay, got it. Will amend this.

> Thanks,
> Miquèl

Thanks,
Apurva Nandan