Re: [PATCH v5 04/12] x86/tdx: Add protected guest support for TDX guest

From: Borislav Petkov
Date: Fri Aug 20 2021 - 10:27:34 EST


On Thu, Aug 12, 2021 at 10:18:39AM -0700, Kuppuswamy, Sathyanarayanan wrote:
> I can implement intel_prot_guest_has() in arch/x86/kernel/cpu/intel.c.
> And call tdx_prot_guest_has() from it.

No, you should simply implement intel_prot_guest_has() or whatever we
end up calling it and have the generic routine call it. Not two routines
- tdx_* and intel_*

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette