From: jing yangyang <jing.yangyang@xxxxxxxxxx>^^^^
Replace a printk+WARN_ON() by a WARN(); this increases the chance of
the string making it into the bugreport^^^^^^^
This issue was detected with the help of Coccinelle.
Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: jing yangyang <jing.yangyang@xxxxxxxxxx>
---
arch/ia64/kernel/iosapic.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/ia64/kernel/iosapic.c b/arch/ia64/kernel/iosapic.c
index 35adcf8..cb8ba1c 100644
--- a/arch/ia64/kernel/iosapic.c
+++ b/arch/ia64/kernel/iosapic.c
@@ -794,17 +794,13 @@ static inline unsigned char choose_dmode(void)
*/
irq = gsi_to_irq(gsi);
if (irq < 0) {
- printk(KERN_ERR "iosapic_unregister_intr(%u) unbalanced\n",
- gsi);
- WARN_ON(1);
+ WARN_ON(1, "iosapic_unregister_intr(%u) unbalanced\n", gsi);
return;^^^^^^^
}
spin_lock_irqsave(&iosapic_lock, flags);
if ((rte = find_rte(irq, gsi)) == NULL) {
- printk(KERN_ERR "iosapic_unregister_intr(%u) unbalanced\n",
- gsi);
- WARN_ON(1);
+ WARN_ON(1, "iosapic_unregister_intr(%u) unbalanced\n", gsi);
goto out;
}