[PATCH] staging: r8188eu: Fix a resource leak in update_bcn_wps_ie

From: Xiangyang Zhang
Date: Sat Aug 21 2021 - 04:18:54 EST


The "pbackup_remainder_ie" variable is not freed when "pwps_ie_src" is null

Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")
Signed-off-by: Xiangyang Zhang <xyz.sun.ok@xxxxxxxxx>
---
drivers/staging/r8188eu/core/rtw_ap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188eu/core/rtw_ap.c
index 1127e9a52458..2ce982390c7b 100644
--- a/drivers/staging/r8188eu/core/rtw_ap.c
+++ b/drivers/staging/r8188eu/core/rtw_ap.c
@@ -1300,7 +1300,7 @@ static void update_bcn_wps_ie(struct adapter *padapter)

pwps_ie_src = pmlmepriv->wps_beacon_ie;
if (!pwps_ie_src)
- return;
+ goto exit;

wps_ielen = (uint)pwps_ie_src[1];/* to get ie data len */
if ((wps_offset + wps_ielen + 2 + remainder_ielen) <= MAX_IE_SZ) {
@@ -1314,6 +1314,7 @@ static void update_bcn_wps_ie(struct adapter *padapter)
pnetwork->IELength = wps_offset + (wps_ielen + 2) + remainder_ielen;
}

+exit:
kfree(pbackup_remainder_ie);
}

--
2.19.1