Re: [PATCH] ipw2x00: Use struct_size helper instead of open-coded arithmetic

From: Kalle Valo
Date: Sat Aug 21 2021 - 13:15:53 EST


Len Baker <len.baker@xxxxxxx> wrote:

> Dynamic size calculations (especially multiplication) should not be
> performed in memory allocator function arguments due to the risk of them
> overflowing. This could lead to values wrapping around and a smaller
> allocation being made than the caller was expecting. Using those
> allocations could lead to linear overflows of heap memory and other
> misbehaviors.
>
> To avoid this scenario, use the struct_size helper.
>
> Signed-off-by: Len Baker <len.baker@xxxxxxx>

Patch applied to wireless-drivers-next.git, thanks.

6f78f4a41ee0 ipw2x00: Use struct_size helper instead of open-coded arithmetic

--
https://patchwork.kernel.org/project/linux-wireless/patch/20210717142513.5411-1-len.baker@xxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches