Re: [PATCH v1 1/1] ray_cs: use %*ph to print small buffer

From: Joe Perches
Date: Sat Aug 21 2021 - 16:04:33 EST


On Sat, 2021-08-21 at 17:14 +0000, Kalle Valo wrote:
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> > Use %*ph format to print small buffer as hex string.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Patch applied to wireless-drivers-next.git, thanks.
>
> 502213fd8fca ray_cs: use %*ph to print small buffer
>

There's one more of these in the same file but it's in an #ifdef 0 block...
---
drivers/net/wireless/ray_cs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
index 590bd974d94f4..849216fbb8363 100644
--- a/drivers/net/wireless/ray_cs.c
+++ b/drivers/net/wireless/ray_cs.c
@@ -2284,9 +2284,9 @@ static void untranslate(ray_dev_t *local, struct sk_buff *skb, int len)
DUMP_PREFIX_NONE, 16, 1,
skb->data, 64, true);
printk(KERN_DEBUG
- "type = %08x, xsap = %02x%02x%02x, org = %02x02x02x\n",
+ "type = %08x, xsap = %02x%02x%02x, org = %3phN\n",
ntohs(type), psnap->dsap, psnap->ssap, psnap->ctrl,
- psnap->org[0], psnap->org[1], psnap->org[2]);
+ psnap->org);
printk(KERN_DEBUG "untranslate skb->data = %p\n", skb->data);
}
#endif