Re: [PATCH] selftests: openat2: Fix testing failure for O_LARGEFILE flag

[Baolin Wang]

Hi Shuah,

On 2021/7/28 20:32, Baolin Wang wrote:
> Hi,
>
> > When running the openat2 test suite on ARM64 platform, we got below 
> > failure,
> > since the definition of the O_LARGEFILE is different on ARM64. So we can
> > set the correct O_LARGEFILE definition on ARM64 to fix this issue.
>
> Sorry, I forgot to copy the failure log:
>
> # openat2 unexpectedly returned # 
> 3['/lkp/benchmarks/kernel_selftests/tools/testing/selftests/openat2'] 
> with 208000 (!= 208000)
> not ok 102 openat2 with incompatible flags (O_PATH | O_LARGEFILE) fails 
> with -22 (Invalid argument)
>
> > Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>

Could you apply this patch if no objection from your side? Thanks.

> > ---
> >   tools/testing/selftests/openat2/openat2_test.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/tools/testing/selftests/openat2/openat2_test.c 
> > b/tools/testing/selftests/openat2/openat2_test.c
> > index d7ec1e7..1bddbe9 100644
> > --- a/tools/testing/selftests/openat2/openat2_test.c
> > +++ b/tools/testing/selftests/openat2/openat2_test.c
> > @@ -22,7 +22,11 @@
> >    * XXX: This is wrong on {mips, parisc, powerpc, sparc}.
> >    */
> >   #undef    O_LARGEFILE
> > +#ifdef __aarch64__
> > +#define    O_LARGEFILE 0x20000
> > +#else
> >   #define    O_LARGEFILE 0x8000
> > +#endif
> >   struct open_how_ext {
> >       struct open_how inner;