Re: [net-next][bisected da41788] modules fails to build drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12199

[Heiner Kallweit]

On 23.08.2021 08:00, Abdul Haleem wrote:
> Greeting's
> 
> Todays net-next branch fails to build on my powerpc box with below error
> 
>   CC [M]  drivers/gpu/drm/virtio/virtgpu_trace_points.o
>   CC [M]  drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.o
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c: In function ‘bnx2x_read_fwinfo’:
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12199:13: error: implicit declaration of function ‘pci_vpd_alloc’; did you mean ‘pci_pool_alloc’? [-Werror=implicit-function-declaration]
>   vpd_data = pci_vpd_alloc(bp->pdev, &vpd_len);
>              ^~~~~~~~~~~~~
>              pci_pool_alloc
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12199:11: warning: assignment to ‘u8 *’ {aka ‘unsigned char *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
>   vpd_data = pci_vpd_alloc(bp->pdev, &vpd_len);
>            ^
>   CC [M]  drivers/scsi/qla2xxx/qla_nx.o
>   CC [M]  net/netfilter/xt_MASQUERADE.o
>   CC [M]  net/bluetooth/ecdh_helper.o
>   CC [M]  drivers/gpu/drm/amd/amdgpu/uvd_v5_0.o
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12203:9: error: implicit declaration of function ‘pci_vpd_find_ro_info_keyword’; did you mean ‘pci_vpd_find_info_keyword’? [-Werror=implicit-function-declaration]
>   rodi = pci_vpd_find_ro_info_keyword(vpd_data, vpd_len,
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          pci_vpd_find_info_keyword
>   CC [M]  net/netfilter/xt_SECMARK.o
>   CC [M]  net/netfilter/xt_TPROXY.o
>   CC [M]  net/mac80211/driver-ops.o
> 
> 
> The recent changes to the code causing build fail is
> 
> commit da417885a99d36036cc7d2778f94b846e6582434
> Author: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> Date:   Sun Aug 22 15:54:23 2021 +0200
> 
>     bnx2x: Search VPD with pci_vpd_find_ro_info_keyword()
>         Use pci_vpd_find_ro_info_keyword() to search for keywords in VPD to
>     simplify the code.
>         str_id_reg and str_id_cap hold the same string and are used in the same
>     comparison. This doesn't make sense, use one string str_id instead.
>         Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
>     Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> 
> @Heiner, Could you please have a look, I am attaching the kernel config
> 
This series was supposed to go via the PCI tree because it builds on patches
that are in the PCI tree but not in linux-next and net-next yet.