Re: [PATCH] dmaengine: switch from 'pci_' to 'dma_' API

From: Andy Shevchenko
Date: Mon Aug 23 2021 - 03:29:30 EST


On Sun, Aug 22, 2021 at 02:40:22PM +0200, Christophe JAILLET wrote:
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below.
>
> It has been hand modified to use 'dma_set_mask_and_coherent()' instead of
> 'pci_set_dma_mask()/pci_set_consistent_dma_mask()' when applicable.
> This is less verbose.
>
> It has been compile tested.

> @@
> expression e1, e2;
> @@
> - pci_set_consistent_dma_mask(e1, e2)
> + dma_set_coherent_mask(&e1->dev, e2)

Can we, please, replace this long noise in the commit message with a link to a
script in coccinelle data base?

And the same comment for any future submission that are based on the scripts
(esp. coccinelle ones).

...

> This patch is mostly mechanical and compile tested. I hope it is ok to
> update the "drivers/dma/" directory all at once.

There is another discussion with Hellwig [1] about 64-bit DMA mask,
i.e. it doesn't fail anymore, so you need to rework drivers accordingly.

[1]: https://lkml.org/lkml/2021/6/7/398

--
With Best Regards,
Andy Shevchenko