Re: [PATCH 1/3] fs/ntfs3: Fix error code in indx_add_allocate()

[Kari Argillander]

On Tue, Aug 24, 2021 at 10:49:32AM +0300, Dan Carpenter wrote:
> Return -EINVAL if ni_find_attr() fails.  Don't return success.
> 
> Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Good catch. It seems it is like 50/50 if this should be -ENOENT. I
just check what we do else where where !ni_find_attr().

But either way:
Reviewed-by: Kari Argillander <kari.argillander@xxxxxxxxx>

> ---
>  fs/ntfs3/index.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 6aa9540ece47..07d6dee0a4ba 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -1499,6 +1499,7 @@ static int indx_add_allocate(struct ntfs_index *indx, struct ntfs_inode *ni,
>  	alloc = ni_find_attr(ni, NULL, NULL, ATTR_ALLOC, in->name, in->name_len,
>  			     NULL, &mi);
>  	if (!alloc) {
> +		err = -EINVAL;
>  		if (bmp)
>  			goto out2;
>  		goto out1;
> -- 
> 2.20.1
> 
>