Re: [PATCH] Revert "USB: serial: ch341: fix character loss at high transfer rates"

From: Willy Tarreau
Date: Tue Aug 24 2021 - 08:32:43 EST


On Tue, Aug 24, 2021 at 02:19:26PM +0200, Johan Hovold wrote:
> This reverts commit 3c18e9baee0ef97510dcda78c82285f52626764b.
>
> These devices do not appear to send a zero-length packet when the
> transfer size is a multiple of the bulk-endpoint max-packet size. This
> means that incoming data may not be processed by the driver until a
> short packet is received or the receive buffer is full.
>
> Revert back to using endpoint-sized receive buffers to avoid stalled
> reads.

Sorry for this, I didn't notice any issue here (aside for the chip
working where it used not to). I have no idea what these zero-length
packets correspond to, nor why they're affected by the transfer size.
Do you have any idea what I should look for ? Because without that
patch, the device is unusable for me :-/

Thanks!
Willy