Re: [PATCH v2 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node

[Geert Uytterhoeven]

Hi Bin,

On Wed, Aug 4, 2021 at 2:30 PM Bin Meng <bmeng.cn@xxxxxxxxx> wrote:
> From: Bin Meng <bin.meng@xxxxxxxxxxxxx>
>
> U-Boot expects this alias to be in place in order to fix up the mac
> address of the ethernet node.
>
> Note on the Icicle Kit board, currently only emac1 is enabled so it
> becomes the 'ethernet0'.
>
> Signed-off-by: Bin Meng <bin.meng@xxxxxxxxxxxxx>
>
> ---
>
> Changes in v2:
> - move the aliases node to board dts

Thanks for the update!

> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> @@ -14,6 +14,10 @@ / {
>         model = "Microchip PolarFire-SoC Icicle Kit";
>         compatible = "microchip,mpfs-icicle-kit";
>
> +       aliases {
> +               ethernet0 = &emac1;
> +       };
> +
>         chosen {
>                 stdout-path = &serial0;
>         };

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

BTW, is Ethernet working in Linux for you?
IP-Config is always timing out for me.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds