Re: [PATCH 5/9] spi: amd: Refactor amd_spi_busy_wait to use readl_poll_timeout

From: Mark Brown
Date: Tue Aug 24 2021 - 12:47:20 EST


On Tue, Aug 24, 2021 at 11:40:37AM +0100, Lucas Tanure wrote:

> - spi_busy = (ioread32((u8 __iomem *)amd_spi->io_remap_addr +
> - AMD_SPI_CTRL0_REG) & AMD_SPI_BUSY) == AMD_SPI_BUSY;

This does ioread32() while readl_poll_timeout() does a readl(). These
are almost but not quite equivalent and the differences apply to PCI
devices like this one, see device-io.rst.

Attachment: signature.asc
Description: PGP signature