Re: [PATCH 5.10 10/98] vdpa: Define vdpa mgmt device, ops and a netlink interface

[Pavel Machek]

Hi!

> From: Parav Pandit <parav@xxxxxxxxxx>
> 
> [ Upstream commit 33b347503f014ebf76257327cbc7001c6b721956 ]
> 
> To add one or more VDPA devices, define a management device which
> allows adding or removing vdpa device. A management device defines
> set of callbacks to manage vdpa devices.
> 
> To begin with, it defines add and remove callbacks through which a user
> defined vdpa device can be added or removed.

This looks quite intrusive; is it meant to be in -stable, or is it
some kind of mistake?

Best regards,
									Pavel
									

> Signed-off-by: Parav Pandit <parav@xxxxxxxxxx>
> Reviewed-by: Eli Cohen <elic@xxxxxxxxxx>
> Reviewed-by: Jason Wang <jasowang@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20210105103203.82508-4-parav@xxxxxxxxxx
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> 
> Including a bugfix:
> 
> vpda: correctly size vdpa_nl_policy
> 
> We need to ensure last entry of vdpa_nl_policy[]
> is zero, otherwise out-of-bounds access is hurting us.
> 
> Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Reported-by: syzbot <syzkaller@xxxxxxxxxxxxxxxx>
> Cc: Parav Pandit <parav@xxxxxxxxxx>
> Cc: Eli Cohen <elic@xxxxxxxxxx>
> Cc: Jason Wang <jasowang@xxxxxxxxxx>
> Cc: Michael S. Tsirkin <mst@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20210210134911.4119555-1-eric.dumazet@xxxxxxxxx
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
>  drivers/vdpa/Kconfig      |   1 +
>  drivers/vdpa/vdpa.c       | 213 +++++++++++++++++++++++++++++++++++++-
>  include/linux/vdpa.h      |  31 ++++++
>  include/uapi/linux/vdpa.h |  31 ++++++
>  4 files changed, 275 insertions(+), 1 deletion(-)
>  create mode 100644 include/uapi/linux/vdpa.h

-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: PGP signature