Re: [PATCH v1] arm64: dts: qcom: sc7280: Add clock controller ID headers
From: Doug Anderson
Date: Tue Aug 24 2021 - 18:52:33 EST
Hi,
On Tue, Aug 10, 2021 at 5:43 PM Taniya Das <tdas@xxxxxxxxxxxxxx> wrote:
>
> Add the GPUCC, DISPCC and VIDEOCC clock headers which were dropped
> earlier.
>
> Fixes: 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes")
IMO drop the "Fixes". To me having the "Fixes" there means that there
was a bug in the old patch. This isn't really fixing a bug.
> Signed-off-by: Taniya Das <tdas@xxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
Other than removing the "Fixes" then this seems like it would be nice
to land soon after the next -rc1 comes out so that patches that start
referring to the clocks in these controllers can take advantage of
them. Snooze 3 weeks till (presumably) -rc1 might come out.
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>