Re: [PATCH] selftests/bpf: Use kselftest skip code for skipped tests

[Dylan Hatch]

On Sun, Aug 22, 2021 at 8:12 PM Po-Hsu Lin <po-hsu.lin@xxxxxxxxxxxxx> wrote:
>
> There are several test cases in the bpf directory are still using
> exit 0 when they need to be skipped. Use kselftest framework skip
> code instead so it can help us to distinguish the return status.
>
> Criterion to filter out what should be fixed in bpf directory:
>   grep -r "exit 0" -B1 | grep -i skip
>
> This change might cause some false-positives if people are running
> these test scripts directly and only checking their return codes,
> which will change from 0 to 4. However I think the impact should be
> small as most of our scripts here are already using this skip code.
> And there will be no such issue if running them with the kselftest
> framework.
>
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@xxxxxxxxxxxxx>
Reviewed-By: Dylan Hatch <dylanbhatch@xxxxxxxxxx>