Re: [PATCH] dt-bindings: Use 'enum' instead of 'oneOf' plus 'const' entries

From: Vinod Koul
Date: Wed Aug 25 2021 - 10:03:08 EST


On 24-08-21, 15:20, Rob Herring wrote:
> 'enum' is equivalent to 'oneOf' with a list of 'const' entries, but 'enum'
> is more concise and yields better error messages.
>
> Cc: Vinod Koul <vkoul@xxxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: Vignesh R <vigneshr@xxxxxx>
> Cc: Marc Zyngier <maz@xxxxxxxxxx>
> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Cc: Kishon Vijay Abraham I <kishon@xxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Cc: dmaengine@xxxxxxxxxxxxxxx
> Cc: linux-i2c@xxxxxxxxxxxxxxx
> Cc: linux-media@xxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> Cc: linux-pci@xxxxxxxxxxxxxxx
> Cc: linux-phy@xxxxxxxxxxxxxxxxxxx
> Cc: linux-serial@xxxxxxxxxxxxxxx
> Cc: alsa-devel@xxxxxxxxxxxxxxxx
> Cc: linux-spi@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> .../bindings/display/msm/dsi-phy-10nm.yaml | 6 +++---
> .../bindings/display/msm/dsi-phy-14nm.yaml | 6 +++---
> .../bindings/display/msm/dsi-phy-28nm.yaml | 8 ++++----

Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx>

> .../bindings/dma/allwinner,sun6i-a31-dma.yaml | 12 ++++++------
> .../devicetree/bindings/phy/intel,lgm-emmc-phy.yaml | 6 +++---

Acked-By: Vinod Koul <vkoul@xxxxxxxxxx>

--
~Vinod